Disable PublishTrimmed for Release so the release pipeline can publish#18
Merged
Merged
Conversation
The first release run failed with NETSDK1144 (Optimizing assemblies for
size failed). Root cause: trimming is on for Release configurations,
and three trim issues add up to a build break under TreatWarningsAsErrors:
- IL2026 on JsonSerializer.{Deserialize,Serialize}Async in JsonSnipStore
and JsonSettingsStore — the reflection-based overloads carry
RequiresUnreferencedCodeAttribute.
- IL2104 from Jdenticon-net, Microsoft.Windows.SDK.NET, and
WinRT.Runtime, which all produce trim warnings of their own.
Switching PublishTrimmed off unblocks the release. Re-enabling is
captured in TODO.md as the proper follow-up — it wants JsonSerializer
to move onto a source-generated JsonSerializerContext plus an audit of
the third-party trim warnings.
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
release.ymlrun (tagv0.1.0-alpha.1) failed withNETSDK1144: Optimizing assemblies for size failed.Snipdeck.App.csproj(template default). Three IL2026/IL2104 issues stack into a build break underTreatWarningsAsErrors:JsonSerializer.{Deserialize,Serialize}AsyncinJsonSnipStore/JsonSettingsStore— the reflection-based overloads carryRequiresUnreferencedCodeAttribute.PublishTrimmed(always) for now. Self-contained binary will be larger, but the release pipeline can complete. Re-enabling is the proper follow-up (move JSON ontoJsonSerializerContextsource-gen + audit third-party warnings) — adding that to TODO.md in a separate PR.Notes
v0.1.0-alpha.1tag exists on the remote but has no associated GitHub release (the workflow failed before the release-creation step). I'll delete the tag, then re-cut from master after this PR lands.Test plan
🤖 Generated with Claude Code